Bug 191251

Summary: Remove some virtual methods in CachedRawResource
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ews-watchlist, fred.wang, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2018-11-05 01:25:01 PST
Remove some virtual methods in CachedRawResource, as CachedRawResource is final no need to introduce new virtual methods in CachedRawResource.
Attachments
Patch (1.98 KB, patch)
2018-11-05 01:27 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (2.07 KB, patch)
2018-11-05 04:59 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (2.07 KB, patch)
2018-11-05 05:15 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-11-05 01:27:18 PST
Created attachment 353837 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2018-11-05 04:50:59 PST
Comment on attachment 353837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review > Source/WebCore/loader/cache/CachedRawResource.h:-40 > - // This can be fixed by splitting CORS preflighting out of DocumentThreacableLoader. What's this FIXME referring to? Is it just an obsolete comment? Can you mention in the ChangeLog why we remove this?
Frédéric Wang (:fredw)
Comment 3 2018-11-05 04:52:05 PST
Comment on attachment 353837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review > Source/WebCore/loader/cache/CachedRawResource.h:-32 > -class SubresourceLoader; Can we also briefly mention this change in the ChangeLog too?
Rob Buis
Comment 4 2018-11-05 04:59:32 PST
Created attachment 353851 [details] Patch
Rob Buis
Comment 5 2018-11-05 05:00:22 PST
Comment on attachment 353851 [details] Patch Updated commit message after Fred's feedback.
WebKit Commit Bot
Comment 6 2018-11-05 05:02:01 PST
Comment on attachment 353851 [details] Patch Rejecting attachment 353851 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 353851, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9863899
Rob Buis
Comment 7 2018-11-05 05:15:59 PST
Created attachment 353852 [details] Patch
WebKit Commit Bot
Comment 8 2018-11-05 05:55:28 PST
Comment on attachment 353852 [details] Patch Clearing flags on attachment: 353852 Committed r237797: <https://trac.webkit.org/changeset/237797>
WebKit Commit Bot
Comment 9 2018-11-05 05:55:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-11-05 05:56:22 PST
<rdar://problem/45805544>
Note You need to log in before you can comment on or make changes to this bug.