Bug 191231

Summary: [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, lforschler, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix a typo
none
Patch for EWS none

Wenson Hsieh
Reported 2018-11-03 19:09:36 PDT
SSIA — just cleaning up some duplicated code.
Attachments
Patch (16.12 KB, patch)
2018-11-03 19:51 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix a typo (16.08 KB, patch)
2018-11-03 19:57 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for EWS (16.20 KB, patch)
2018-11-04 12:21 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-11-03 19:51:40 PDT
Created attachment 353791 [details] Patch
Wenson Hsieh
Comment 2 2018-11-03 19:57:09 PDT
Created attachment 353793 [details] Fix a typo
Wenson Hsieh
Comment 3 2018-11-04 12:14:30 PST
Comment on attachment 353793 [details] Fix a typo View in context: https://bugs.webkit.org/attachment.cgi?id=353793&action=review Thanks for the review! > Tools/WebKitTestRunner/UIScriptControllerCocoa.mm:146 > + TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView(); > + [webView _findString:toWTFString(toWK(string)) options:options maxCount:maxCount]; (Oops, this should be guarded under `WK_API_ENABLED` to fix the 32-bit build)
Wenson Hsieh
Comment 4 2018-11-04 12:21:01 PST
Created attachment 353806 [details] Patch for EWS
WebKit Commit Bot
Comment 5 2018-11-04 13:19:51 PST
Comment on attachment 353806 [details] Patch for EWS Clearing flags on attachment: 353806 Committed r237786: <https://trac.webkit.org/changeset/237786>
WebKit Commit Bot
Comment 6 2018-11-04 13:19:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-04 13:20:18 PST
<rdar://problem/45794523>
Note You need to log in before you can comment on or make changes to this bug.