Bug 191223

Summary: [WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: aboya, bugs-noreply, calvaris, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Description Michael Catanzaro 2018-11-02 19:49:49 PDT 
Since we need to support old versions of GStreamer, and that requires disabling ENABLE_MEDIA_SOURCE, we should expose it as a public option. It's pretty weird to tell users that they need to disable a secret hidden option in order to build WebKit.
Comment 1 Michael Catanzaro 2018-11-02 22:10:33 PDT 
Created attachment 353763 [details]
Patch
Comment 2 Michael Catanzaro 2018-11-02 22:19:16 PDT 
Created attachment 353764 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2018-11-04 23:38:34 PST 
Comment on attachment 353764 [details]
Patch

IMHO, what was weird was that this was private in the first place.
Comment 4 WebKit Commit Bot 2018-11-05 00:03:37 PST 
Comment on attachment 353764 [details]
Patch

Clearing flags on attachment: 353764

Committed r237791: <https://trac.webkit.org/changeset/237791>
Comment 5 WebKit Commit Bot 2018-11-05 00:03:39 PST 
All reviewed patches have been landed.  Closing bug.