Bug 191211

Summary:

REGRESSION (r237735?): [ MacOS WK2 ] Layout Test http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html is a flaky timeout

Product:

WebKit

Reporter:

Truitt Savell <tsavell>

Component:

Tools / Tests

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, jlewis3, lforschler, ryanhaddad, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Truitt Savell

Reported 2018-11-02 14:27:51 PDT

The following layout test is flaky on MacOS WK2 http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html Probable cause: This test has been slightly flakey for a while, within the last few revisions it has become significantly flakey. r237735 is around where this increased flakiness began. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fremove-blocking-in-redirect.html

Attachments
Patch (4.82 KB, patch) 2019-01-14 16:16 PST, John Wilander	no flags	Details Formatted Diff Diff
Patch for landing (4.82 KB, patch) 2019-01-14 17:13 PST, John Wilander	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Truitt Savell

Comment 1 2018-11-02 15:39:04 PDT

looks like this issue came from https://trac.webkit.org/changeset/237735/webkit

Chris Dumez

Comment 2 2018-11-02 15:48:44 PDT

http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html is indeed impacted by r237735 as the test navigates from origin A to origin B and then back to A. We are now using the same process both both loads of origin A instead of 2 separate processes. That said, my change only impacted the timing of things by reusing an existing process instead of spinning up a fresh new one. The test was already flaky so patches impacting timing can definitely make flaky tests more or less flaky. That said, the issue is not with r237735 but rather with the test being flaky in the first place.

Radar WebKit Bug Importer

Comment 3 2018-11-05 13:44:51 PST

<rdar://problem/45818606>

John Wilander

Comment 4 2019-01-14 16:16:54 PST

Created attachment 359094 [details] Patch

John Wilander

Comment 5 2019-01-14 16:17:37 PST

Uploaded an attempt to address the flakiness.

John Wilander

Comment 6 2019-01-14 16:48:22 PST

mac-wk2 failing tests are unrelated.

John Wilander

Comment 7 2019-01-14 17:13:45 PST

Created attachment 359100 [details] Patch for landing

WebKit Commit Bot

Comment 8 2019-01-14 17:51:20 PST

Comment on attachment 359100 [details] Patch for landing Clearing flags on attachment: 359100 Committed r239966: <https://trac.webkit.org/changeset/239966>

WebKit Commit Bot

Comment 9 2019-01-14 17:51:21 PST

All reviewed patches have been landed. Closing bug.

John Wilander

Comment 10 2019-01-15 10:55:20 PST

I just had a look at the flakiness dashboard and the test has improved significantly after the change.

Note You need to log in before you can comment on or make changes to this bug.