Bug 191210

Summary:

[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold

Product:

WebKit

Reporter:

Ali Juma <ajuma>

Component:

Layout and Rendering

Assignee:

Ali Juma <ajuma>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

159475

Attachments:

Description	Flags
Patch	none

Description Ali Juma 2018-11-02 14:27:23 PDT

isIntersecting should be false if the intersection ratio is smaller than the smallest threshold value. We currently set it to true whenever the intersection ratio is non-zero, but that's incorrect if the smallest threshold is non-zero.

Comment 1 Ali Juma 2018-11-02 14:31:35 PDT

Created attachment 353732 [details]
Patch

Comment 2 WebKit Commit Bot 2018-11-05 06:47:49 PST

Comment on attachment 353732 [details]
Patch

Clearing flags on attachment: 353732

Committed r237798: <https://trac.webkit.org/changeset/237798>

Comment 3 WebKit Commit Bot 2018-11-05 06:47:51 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2018-11-05 06:48:24 PST

<rdar://problem/45806230>