Bug 191210 - [IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
Summary: [IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks: 159475
  Show dependency treegraph
 
Reported: 2018-11-02 14:27 PDT by Ali Juma
Modified: 2018-11-05 06:48 PST (History)
10 users (show)

See Also:


Attachments
Patch (3.28 KB, patch)
2018-11-02 14:31 PDT, Ali Juma
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-11-02 14:27:23 PDT
isIntersecting should be false if the intersection ratio is smaller than the smallest threshold value. We currently set it to true whenever the intersection ratio is non-zero, but that's incorrect if the smallest threshold is non-zero.
Comment 1 Ali Juma 2018-11-02 14:31:35 PDT
Created attachment 353732 [details]
Patch
Comment 2 WebKit Commit Bot 2018-11-05 06:47:49 PST
Comment on attachment 353732 [details]
Patch

Clearing flags on attachment: 353732

Committed r237798: <https://trac.webkit.org/changeset/237798>
Comment 3 WebKit Commit Bot 2018-11-05 06:47:51 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-11-05 06:48:24 PST
<rdar://problem/45806230>