Bug 191205

Summary: Improve the SVG blog post icon approach
Product: WebKit Reporter: Jon Davis <jond>
Component: WebKit WebsiteAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jond, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jon Davis 2018-11-02 13:01:27 PDT 
The current SVG icon approach for blog posts uses an SVG sprite sheet that is positioned with percentage based background-position-y. It makes it very hard to add new icons. We need a new approach that makes it easy to specify add new icons and easily fallback to a default icon.
Comment 1 Jon Davis 2018-11-02 13:53:21 PDT 
Created attachment 353726 [details]
Patch
Comment 2 Timothy Hatcher 2018-11-02 14:02:58 PDT 
Comment on attachment 353726 [details]
Patch

Nice!
Comment 3 WebKit Commit Bot 2018-11-02 14:43:49 PDT 
Comment on attachment 353726 [details]
Patch

Clearing flags on attachment: 353726

Committed r237752: <https://trac.webkit.org/changeset/237752>
Comment 4 WebKit Commit Bot 2018-11-02 14:43:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-02 14:44:18 PDT 
<rdar://problem/45773768>