Bug 191199

Summary: REGRESSION (r237699): Layout Test http/tests/security/anchor-download-block-crossorigin.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, dewei_zhu, ggaren, jlewis3, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2018-11-02 10:30:13 PDT
The following layout test is frequently failing on macOS WK2 http/tests/security/anchor-download-block-crossorigin.html Probable cause: This appears to have regressed with https://trac.webkit.org/changeset/237699/webkit Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fanchor-download-block-crossorigin.html --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/security/anchor-download-block-crossorigin-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/security/anchor-download-block-crossorigin-actual.txt @@ -1,2 +1 @@ -CONSOLE MESSAGE: line 24: The download attribute on anchor was ignored because its href URL has a different security origin. PASS
Attachments
Patch (2.95 KB, patch)
2018-11-02 14:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-11-02 10:32:29 PDT
I can reproduce the failure with the following: run-webkit-tests http/tests/security/anchor-download-block-crossorigin.html -fg --iter 10 --no-retry I cannot reproduce the failure with r237698, I can with r237699.
Chris Dumez
Comment 2 2018-11-02 11:06:15 PDT
(In reply to Ryan Haddad from comment #1) > I can reproduce the failure with the following: > run-webkit-tests http/tests/security/anchor-download-block-crossorigin.html > -fg --iter 10 --no-retry > > I cannot reproduce the failure with r237698, I can with r237699. Ok, will investigate today. Thanks.
Chris Dumez
Comment 3 2018-11-02 14:51:20 PDT
Created attachment 353734 [details] Patch
WebKit Commit Bot
Comment 4 2018-11-02 17:06:16 PDT
Comment on attachment 353734 [details] Patch Clearing flags on attachment: 353734 Committed r237760: <https://trac.webkit.org/changeset/237760>
WebKit Commit Bot
Comment 5 2018-11-02 17:06:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-02 17:07:22 PDT
<rdar://problem/45777769>
Note You need to log in before you can comment on or make changes to this bug.