REGRESSION (r237699): Layout Test http/tests/security/anchor-download-block-crossorigin.html is a flaky failure

[Ryan Haddad]

The following layout test is frequently failing on macOS WK2

http/tests/security/anchor-download-block-crossorigin.html

Probable cause:

This appears to have regressed with https://trac.webkit.org/changeset/237699/webkit

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fanchor-download-block-crossorigin.html

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/security/anchor-download-block-crossorigin-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/security/anchor-download-block-crossorigin-actual.txt
@@ -1,2 +1 @@
-CONSOLE MESSAGE: line 24: The download attribute on anchor was ignored because its href URL has a different security origin.
 PASS

[Ryan Haddad]

I can reproduce the failure with the following:
run-webkit-tests http/tests/security/anchor-download-block-crossorigin.html -fg --iter 10 --no-retry

I cannot reproduce the failure with r237698, I can with r237699.

[Chris Dumez]

(In reply to Ryan Haddad from comment #1)
> I can reproduce the failure with the following:
> run-webkit-tests http/tests/security/anchor-download-block-crossorigin.html
> -fg --iter 10 --no-retry
> 
> I cannot reproduce the failure with r237698, I can with r237699.

Ok, will investigate today. Thanks.

[Chris Dumez]

Created attachment 353734 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 353734 [details]
Patch

Clearing flags on attachment: 353734

Committed r237760: <https://trac.webkit.org/changeset/237760>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45777769>