Bug 191190

Summary: Enable LLInt on ARMv7/Linux
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, fpizlo, guijemont, saam, thorton, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191163    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Dominik Inführ
Reported 2018-11-02 06:31:06 PDT
Enable LLInt on ARMv7/Linux
Attachments
Patch (14.71 KB, patch)
2018-11-02 06:43 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (14.70 KB, patch)
2018-11-02 06:49 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (14.70 KB, patch)
2018-11-02 08:20 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (14.97 KB, patch)
2018-11-05 00:13 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-11-02 06:43:25 PDT
Created attachment 353691 [details] Patch
Dominik Inführ
Comment 2 2018-11-02 06:49:09 PDT
Created attachment 353692 [details] Patch
Dominik Inführ
Comment 3 2018-11-02 08:20:53 PDT
Created attachment 353704 [details] Patch
Yusuke Suzuki
Comment 4 2018-11-02 19:44:21 PDT
Comment on attachment 353704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353704&action=review r=me > Source/JavaScriptCore/jit/GPRInfo.h:564 > + static const GPRReg regCS0 = ARMRegisters::r11; Put `regCS0` definition just after `regTx` temporary registers. > Source/JavaScriptCore/offlineasm/arm.rb:137 > + "r11" Update the document in arm.rb's header.
Dominik Inführ
Comment 5 2018-11-05 00:13:25 PST
Created attachment 353833 [details] Patch
EWS Watchlist
Comment 6 2018-11-05 01:47:11 PST
Comment on attachment 353833 [details] Patch Attachment 353833 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/9861865 New failing tests: stress/regexp-compile-oom.js.dfg-maximal-flush-validate-no-cjit stress/const-semantics.js.dfg-eager apiTests
Dominik Inführ
Comment 7 2018-11-05 07:42:28 PST
Test failures not related to this patch.
WebKit Commit Bot
Comment 8 2018-11-05 08:07:47 PST
Comment on attachment 353833 [details] Patch Clearing flags on attachment: 353833 Committed r237803: <https://trac.webkit.org/changeset/237803>
WebKit Commit Bot
Comment 9 2018-11-05 08:07:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-11-05 08:08:26 PST
<rdar://problem/45807492>
Note You need to log in before you can comment on or make changes to this bug.