Bug 191173

Summary: Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Nikita Vasilyev
Reported 2018-11-01 15:02:41 PDT
Steps: 1. Reload Web Inspector This uncaught exceptions *may* happen: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67) selected @ ScopeBarItem.js:87:67 _populate @ ScopeBar.js:138:34 ScopeBar @ ScopeBar.js:40:23 LogContentView @ LogContentView.js:96:53 createFromRepresentedObject @ ContentView.js:156:41 contentViewForRepresentedObject @ ContentView.js:205:72 contentLoaded @ Main.js:256:81 ? @ [native code] TypeError: undefined is not an object (evaluating 'this.modifierKeys.metaKey') (at Main.js:1458:45) _updateModifierKeys @ Main.js:1458:45 _mouseMoved @ Main.js:1488:29 ? @ [native code]
Attachments
Patch (1.90 KB, patch)
2018-11-01 15:33 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2018-11-01 15:33:46 PDT
Created attachment 353651 [details] Patch This was likely a recent regression. Regardless of that, it was odd to have `WI.modifierKeys` initialized somewhere in the middle of WI.contentLoaded — it should come before that.
Devin Rousso
Comment 2 2018-11-01 15:38:58 PDT
r=me
WebKit Commit Bot
Comment 3 2018-11-01 16:24:24 PDT
Comment on attachment 353651 [details] Patch Clearing flags on attachment: 353651 Committed r237705: <https://trac.webkit.org/changeset/237705>
WebKit Commit Bot
Comment 4 2018-11-01 16:24:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-11-01 16:25:20 PDT
<rdar://problem/45746695>
Note You need to log in before you can comment on or make changes to this bug.