Bug 191172

Summary: Remove ENABLE_OPENCL fully
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, kondapallykalyan, rbuis, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2018-11-01 14:56:38 PDT
There's still some ENABLE(OPENCL) code hanging out in the repository.
Attachments
Patch (3.29 KB, patch)
2018-11-02 07:17 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (2.43 KB, patch)
2018-11-04 05:48 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-11-02 07:17:52 PDT
Created attachment 353697 [details] Patch
Yusuke Suzuki
Comment 2 2018-11-02 07:24:40 PDT
Comment on attachment 353697 [details] Patch r=me. Nobody is using ENABLE(OPENCL). And we do not have implementations.
WebKit Commit Bot
Comment 3 2018-11-02 08:39:59 PDT
Comment on attachment 353697 [details] Patch Clearing flags on attachment: 353697 Committed r237732: <https://trac.webkit.org/changeset/237732>
WebKit Commit Bot
Comment 4 2018-11-02 08:40:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-11-02 08:40:21 PDT
<rdar://problem/45762732>
Don Olmstead
Comment 6 2018-11-02 10:48:03 PDT
Comment on attachment 353697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353697&action=review Beat me to the patch :) Anyways I didn't throw it up because of the applyAll still being there. Seems like that was just there for OPENCL support so it should probably go as well. > Source/WebCore/platform/graphics/filters/FilterEffect.h:96 > inline void applyAll() { apply(); } Should this still be here?
Rob Buis
Comment 7 2018-11-02 10:50:57 PDT
Hi Don, right I took the gamble since you did not assign to yourself :) The applyAll seems not needed, if you want to do a patch feel free, otherwise I can do it tomorrow.
Rob Buis
Comment 8 2018-11-04 05:48:06 PST
Reopening to attach new patch.
Rob Buis
Comment 9 2018-11-04 05:48:09 PST
Created attachment 353802 [details] Patch
Yusuke Suzuki
Comment 10 2018-11-04 17:51:05 PST
Comment on attachment 353802 [details] Patch r=me
WebKit Commit Bot
Comment 11 2018-11-04 18:15:56 PST
Comment on attachment 353802 [details] Patch Clearing flags on attachment: 353802 Committed r237787: <https://trac.webkit.org/changeset/237787>
WebKit Commit Bot
Comment 12 2018-11-04 18:15:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.