Bug 191128

Summary: [MSE] WebKit tests: Use fixed point in makeASample()
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: MediaAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2018-10-31 13:08:21 PDT
This patch modifies the utility function makeASample() so as to accept time values in arbitrary time scales. Previously makeASample() accepted optionally a time scale, but still required to receive all time values as seconds, therefore requiring a division at call time in order to use the function, which could cause rounding errors (see https://bugs.webkit.org/show_bug.cgi?id=190085#c20).
Attachments
Patch (83.91 KB, patch)
2018-10-31 13:09 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2018-10-31 13:09:54 PDT
Created attachment 353523 [details] Patch
Jer Noble
Comment 2 2018-10-31 13:29:30 PDT
LGTM!
WebKit Commit Bot
Comment 3 2018-10-31 14:04:16 PDT
Comment on attachment 353523 [details] Patch Clearing flags on attachment: 353523 Committed r237651: <https://trac.webkit.org/changeset/237651>
WebKit Commit Bot
Comment 4 2018-10-31 14:04:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-10-31 14:05:57 PDT
<rdar://problem/45711338>
Note You need to log in before you can comment on or make changes to this bug.