Bug 191115

Summary: Adjust inlining threshold for new bytecode format
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Tadeu Zagallo
Reported 2018-10-31 08:27:58 PDT
The new format changed the number of operands for many opcodes, which changed inlining decisions and impacted performance negatively.
Attachments
Patch (1.66 KB, patch)
2018-10-31 08:29 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.65 KB, patch)
2018-10-31 11:07 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2018-10-31 08:29:53 PDT
Created attachment 353494 [details] Patch
Saam Barati
Comment 2 2018-10-31 11:00:02 PDT
Comment on attachment 353494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353494&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + The new format changed the number of operands for many opcodes, which I think it's worth noting that you often made it so we had fewer operands, not more. > Source/JavaScriptCore/runtime/Options.h:306 > + v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 120, Normal, nullptr) \ I wonder if this obviates that test you just added.
Tadeu Zagallo
Comment 3 2018-10-31 11:07:10 PDT
Created attachment 353507 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-10-31 11:44:20 PDT
Comment on attachment 353507 [details] Patch for landing Clearing flags on attachment: 353507 Committed r237645: <https://trac.webkit.org/changeset/237645>
WebKit Commit Bot
Comment 5 2018-10-31 11:44:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-31 11:45:28 PDT
<rdar://problem/45707063>
Note You need to log in before you can comment on or make changes to this bug.