Bug 191094

Summary: [lldb-webkit] Fix formatting nits in Document and Frame summary strings
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2018-10-30 17:04:48 PDT
Format boolean as 1/0 when printing Frame summary and substitute "inMainFrame" for "isMainFrame" in Document summary.
Attachments
Patch (2.10 KB, patch)
2018-10-30 17:05 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.19 KB, patch)
2018-10-31 11:21 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-10-30 17:05:26 PDT
Created attachment 353440 [details] Patch
Daniel Bates
Comment 2 2018-10-30 21:27:47 PDT
Comment on attachment 353440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353440&action=review > Tools/lldb/lldb_webkit.py:212 > + return '{ origin = %s, url = %s, isMainFrame = %d, pageCacheState = %s' % (origin, url, provider.is_main_frame(), pageCacheState) Oops! I also forgot the closing '}'. So this line should read: return '{ origin = %s, url = %s, isMainFrame = %d, pageCacheState = %s }' % (origin, url, provider.is_main_frame(), pageCacheState) > Tools/lldb/lldb_webkit.py:219 > + return '{ origin = %s, url = %s, inMainFrame = %s, pageCacheState = %s' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state()) Oops! I also forgot the closing '}'. So this line should read: return '{ origin = %s, url = %s, inMainFrame = %s, pageCacheState = %s }' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state())
Daniel Bates
Comment 3 2018-10-31 11:21:35 PDT
Created attachment 353510 [details] Patch
Daniel Bates
Comment 4 2018-11-05 11:35:50 PST
Comment on attachment 353510 [details] Patch Clearing flags on attachment: 353510 Committed r237822: <https://trac.webkit.org/changeset/237822>
Daniel Bates
Comment 5 2018-11-05 11:35:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-05 11:36:24 PST
<rdar://problem/45814199>
Note You need to log in before you can comment on or make changes to this bug.