| Summary: | [lldb-webkit] Fix formatting nits in Document and Frame summary strings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aestes, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Bates
2018-10-30 17:04:48 PDT
Created attachment 353440 [details]
Patch
Comment on attachment 353440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353440&action=review > Tools/lldb/lldb_webkit.py:212 > + return '{ origin = %s, url = %s, isMainFrame = %d, pageCacheState = %s' % (origin, url, provider.is_main_frame(), pageCacheState) Oops! I also forgot the closing '}'. So this line should read: return '{ origin = %s, url = %s, isMainFrame = %d, pageCacheState = %s }' % (origin, url, provider.is_main_frame(), pageCacheState) > Tools/lldb/lldb_webkit.py:219 > + return '{ origin = %s, url = %s, inMainFrame = %s, pageCacheState = %s' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state()) Oops! I also forgot the closing '}'. So this line should read: return '{ origin = %s, url = %s, inMainFrame = %s, pageCacheState = %s }' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state()) Created attachment 353510 [details]
Patch
Comment on attachment 353510 [details] Patch Clearing flags on attachment: 353510 Committed r237822: <https://trac.webkit.org/changeset/237822> All reviewed patches have been landed. Closing bug. |