Bug 191091

Summary: Add Basic Django web app for OpenSource EWS
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dean_johnson, ews-watchlist, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191123
https://bugs.webkit.org/show_bug.cgi?id=191131
https://bugs.webkit.org/show_bug.cgi?id=191132
Attachments:
Description Flags
Proposed patch
none
Proposed patch
lforschler: review+
Patch for landing none

Aakash Jain
Reported 2018-10-30 16:24:23 PDT
In order to use Buildbot for EWS (https://bugs.webkit.org/show_bug.cgi?id=179506), we need a web-app which act as an intermediate between Buildbot and Bugzilla. This app will receive patches, submit build request to Buildbot, receives build results from Buildbot, and generate status-bubbles which can be displayed on Bugzilla.
Attachments
Proposed patch (55 bytes, patch)
2018-10-31 11:02 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Proposed patch (25.27 KB, patch)
2018-10-31 11:08 PDT, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
Patch for landing (25.25 KB, patch)
2018-11-02 09:58 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-10-31 11:02:30 PDT
Created attachment 353506 [details] Proposed patch Barebone app, mostly Django auto-generated files, and some placeholder files (like models/patch.py). Keeping this patch short so that it is easy to review. Logic would be added in subsequent patches.
Aakash Jain
Comment 2 2018-10-31 11:08:08 PDT
Created attachment 353508 [details] Proposed patch
EWS Watchlist
Comment 3 2018-10-31 11:10:56 PDT
Attachment 353508 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/EWS_app/manage.py:42: whitespace before ')' [pep8/E202] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Lucas Forschler
Comment 4 2018-11-01 13:39:10 PDT
Comment on attachment 353508 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=353508&action=review > Tools/BuildSlaveSupport/EWS_app/EWS_app/settings.py:44 > +SECRET_KEY = 'b)6@_-&5hz(s2-qwt()em3@1yt91=@g=!guu_nz&)u5fb0k+he' please remove and rotate pw. > Tools/ChangeLog:9 > + * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django. I'm not familiar with django development, but is it normal to have a subfolder with the same name as the parent? (EWS_app/EWS_app)?
Kocsen Chung
Comment 5 2018-11-01 13:44:06 PDT
Looks good to me, please fix those style errors :).
Aakash Jain
Comment 6 2018-11-02 09:58:10 PDT
Created attachment 353706 [details] Patch for landing > I'm not familiar with django development, but is it normal to have a subfolder with the same name as the parent? (EWS_app/EWS_app)? Yes, that's normal. > please remove and rotate pw. Done. > Looks good to me, please fix those style errors :). Thanks. Fixed.
WebKit Commit Bot
Comment 7 2018-11-02 10:35:50 PDT
Comment on attachment 353706 [details] Patch for landing Clearing flags on attachment: 353706 Committed r237740: <https://trac.webkit.org/changeset/237740>
WebKit Commit Bot
Comment 8 2018-11-02 10:35:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-11-02 10:36:25 PDT
<rdar://problem/45765964>
Note You need to log in before you can comment on or make changes to this bug.