Summary: | Resync XHR Web Platform Tests from upstream | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, dewei_zhu, ews-watchlist, lforschler, rniwa, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 184645 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2018-10-30 15:32:17 PDT
Created attachment 353420 [details]
Patch
Comment on attachment 353420 [details] Patch Attachment 353420 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9785468 New failing tests: imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm Created attachment 353431 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 353420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353420&action=review > LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34 > +async_test(t => { Not critical. Both syntax works, but existing tests uses "(t) =>" instead of "t =>", we may want to be consistent. > LayoutTests/imported/w3c/web-platform-tests/xhr/headers-normalize-response.htm:11 > + client.open("GET", "resources/parse-headers.py?my-custom-header="+encodeURIComponent(val), false); Nit: space for each side of '+'. Comment on attachment 353420 [details] Patch Attachment 353420 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9785666 New failing tests: imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm Created attachment 353438 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
(In reply to dewei_zhu from comment #4) > Comment on attachment 353420 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353420&action=review > > > LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34 > > +async_test(t => { > > Not critical. Both syntax works, but existing tests uses "(t) =>" instead of > "t =>", we may want to be consistent. > > > LayoutTests/imported/w3c/web-platform-tests/xhr/headers-normalize-response.htm:11 > > + client.open("GET", "resources/parse-headers.py?my-custom-header="+encodeURIComponent(val), false); > > Nit: space for each side of '+'. Those are imported tests from upstream, I am not going to modify them. They should be exact copies of upstream. Comment on attachment 353420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353420&action=review >>> LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34 >>> +async_test(t => { >> >> Not critical. Both syntax works, but existing tests uses "(t) =>" instead of "t =>", we may want to be consistent. > > Those are imported tests from upstream, I am not going to modify them. They should be exact copies of upstream. I see. Created attachment 353443 [details]
Patch
Comment on attachment 353443 [details] Patch Clearing flags on attachment: 353443 Committed r237618: <https://trac.webkit.org/changeset/237618> All reviewed patches have been landed. Closing bug. |