Bug 191075

Summary: XSLTProcessor should limit max transform depth
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: XMLAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, rniwa, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=67310
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2018-10-30 12:38:09 PDT
XSLTProcessor should limit max transform depth to a reasonable amount. The default for libxslt is currently 3000. <rdar://problem/45531453>
Attachments
Patch v1 (8.52 KB, patch)
2018-10-30 12:46 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (8.72 KB, patch)
2018-10-30 13:01 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2018-10-30 12:46:24 PDT
Created attachment 353398 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2018-10-30 12:59:17 PDT
(In reply to David Kilzer (:ddkilzer) from comment #1) > Created attachment 353398 [details] > Patch v1 Due to soft-linking, I'll need to modify the code to work with Apple platforms (using soft-linking) and non-Apple platforms without soft-linking.
David Kilzer (:ddkilzer)
Comment 3 2018-10-30 13:01:53 PDT
Created attachment 353399 [details] Patch v2
WebKit Commit Bot
Comment 4 2018-10-30 20:36:40 PDT
Comment on attachment 353399 [details] Patch v2 Clearing flags on attachment: 353399 Committed r237620: <https://trac.webkit.org/changeset/237620>
WebKit Commit Bot
Comment 5 2018-10-30 20:36:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.