Bug 191072

Summary: [PlayStation] Enable JavaScriptCore
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, fpizlo, ggaren, mcatanzaro, rniwa, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191038    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Don Olmstead
Reported 2018-10-30 11:07:48 PDT
Enable building for PlayStation up through JavaScriptCore
Attachments
Patch (13.98 KB, patch)
2018-10-30 16:05 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (13.97 KB, patch)
2018-10-30 16:12 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (14.11 KB, patch)
2018-10-30 16:26 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-10-30 16:05:42 PDT
Created attachment 353425 [details] Patch Adds in the PlayStation port building WTF + JSC + TestWTF.
EWS Watchlist
Comment 2 2018-10-30 16:09:02 PDT
Attachment 353425 [details] did not pass style-queue: ERROR: Source/ThirdParty/gtest/PlatformPlayStation.cmake:5: Alphabetical sorting problem. "-DGTEST_HAS_TR1_TUPLE=0" should be before "# There is no <tr1/tuple> header". [list/order] [5] ERROR: Source/ThirdParty/gtest/PlatformPlayStation.cmake:6: Alphabetical sorting problem. "# Posix Regex not present so use gtest implementation" should be before "-DGTEST_HAS_TR1_TUPLE=0". [list/order] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2018-10-30 16:12:52 PDT
Created attachment 353426 [details] Patch
EWS Watchlist
Comment 4 2018-10-30 16:20:16 PDT
Attachment 353426 [details] did not pass style-queue: ERROR: Source/ThirdParty/gtest/PlatformPlayStation.cmake:5: There should be exactly one empty line instead of 0 between "-DGTEST_HAS_POSIX_RE=0 # Posix Regex not present so use gtest implementation" and "-DGTEST_HAS_TR1_TUPLE=0 # There is no <tr1/tuple> header". [list/emptyline] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 5 2018-10-30 16:26:52 PDT
Created attachment 353429 [details] Patch
Brent Fulgham
Comment 6 2018-10-30 17:17:18 PDT
Comment on attachment 353429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353429&action=review These changes all seem well isolated to the PlayStation port. I don't see any reason why this would pose a problem to land, assuming the build system is happy. > CMakeLists.txt:43 > + PlayStation Woohoo! > Tools/Scripts/webkitdirs.pm:2310 > + push @args, '-G "Visual Studio 15"'; Does the PS build not support VS 2017?
Don Olmstead
Comment 7 2018-10-30 20:34:36 PDT
Comment on attachment 353429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353429&action=review Thanks for the review! > Tools/Scripts/webkitdirs.pm:2311 > } Yep we have a visual studio integration!
WebKit Commit Bot
Comment 8 2018-10-30 21:00:53 PDT
Comment on attachment 353429 [details] Patch Clearing flags on attachment: 353429 Committed r237621: <https://trac.webkit.org/changeset/237621>
WebKit Commit Bot
Comment 9 2018-10-30 21:00:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-10-30 21:01:31 PDT
<rdar://problem/45690705>
Note You need to log in before you can comment on or make changes to this bug.