Bug 191065

Summary: Stop using LayerFlushScheduler in WK2
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191103    
Attachments:
Description Flags
patch
thorton: review+
patch none

Description Antti Koivisto 2018-10-30 06:05:28 PDT 
Code gets more understandable when TiledCoreAnimationDrawingArea simply uses RunLoopObserver directly for flush scheduling. LayerFlushScheduler can be later moved to WK1.
Comment 1 Antti Koivisto 2018-10-30 06:12:59 PDT 
Created attachment 353364 [details]
patch
Comment 2 Tim Horton 2018-10-30 10:07:58 PDT 
Comment on attachment 353364 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353364&action=review

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:901
> +    if (layerTreeStateIsFrozen())

Should this just go inside flushLayers()?
Comment 3 Simon Fraser (smfr) 2018-10-30 13:16:02 PDT 
Comment on attachment 353364 [details]
patch

Layer flushing time is going to become our "before paint" hook for firing requestAnimationFrame et (first bits of HTML5 event loop). We should work towards that goal.
Comment 4 Antti Koivisto 2018-10-31 02:19:40 PDT 
Created attachment 353474 [details]
patch
Comment 5 WebKit Commit Bot 2018-10-31 02:56:56 PDT 
Comment on attachment 353474 [details]
patch

Clearing flags on attachment: 353474

Committed r237629: <https://trac.webkit.org/changeset/237629>
Comment 6 WebKit Commit Bot 2018-10-31 02:56:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-31 02:57:22 PDT 
<rdar://problem/45695991>