Bug 191065

Summary: Stop using LayerFlushScheduler in WK2
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191103    
Attachments:
Description Flags
patch
thorton: review+
patch none

Antti Koivisto
Reported 2018-10-30 06:05:28 PDT
Code gets more understandable when TiledCoreAnimationDrawingArea simply uses RunLoopObserver directly for flush scheduling. LayerFlushScheduler can be later moved to WK1.
Attachments
patch (7.52 KB, patch)
2018-10-30 06:12 PDT, Antti Koivisto 		thorton: review+
DetailsFormatted DiffDiff
patch (7.99 KB, patch)
2018-10-31 02:19 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-10-30 06:12:59 PDT
Created attachment 353364 [details] patch
Tim Horton
Comment 2 2018-10-30 10:07:58 PDT
Comment on attachment 353364 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=353364&action=review > Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:901 > + if (layerTreeStateIsFrozen()) Should this just go inside flushLayers()?
Simon Fraser (smfr)
Comment 3 2018-10-30 13:16:02 PDT
Comment on attachment 353364 [details] patch Layer flushing time is going to become our "before paint" hook for firing requestAnimationFrame et (first bits of HTML5 event loop). We should work towards that goal.
Antti Koivisto
Comment 4 2018-10-31 02:19:40 PDT
Created attachment 353474 [details] patch
WebKit Commit Bot
Comment 5 2018-10-31 02:56:56 PDT
Comment on attachment 353474 [details] patch Clearing flags on attachment: 353474 Committed r237629: <https://trac.webkit.org/changeset/237629>
WebKit Commit Bot
Comment 6 2018-10-31 02:56:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-10-31 02:57:22 PDT
<rdar://problem/45695991>
Note You need to log in before you can comment on or make changes to this bug.