Bug 191051

Summary:

Add credit card autofill button

Product:

WebKit

Reporter:

Zach Li <a.tion.surf>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

a.tion.surf, Ayuprama88, cdumez, commit-queue, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews200 for win-future	none
Patch and updated layout tests	none
Patch and updated layout tests	none
Patch and updated layout tests	none
Patch and updated layout tests	none

Zach Li

Reported 2018-10-29 18:15:56 PDT

Add credit card autofill button, rdar://problem/45657011.

Attachments
Patch (24.13 KB, patch) 2018-10-29 18:35 PDT, Zach Li	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.33 MB, application/zip) 2018-10-29 20:33 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews200 for win-future (12.97 MB, application/zip) 2018-10-30 04:38 PDT, EWS Watchlist	no flags	Details
Patch and updated layout tests (30.45 KB, patch) 2018-10-30 11:20 PDT, Zach Li	no flags	Details Formatted Diff Diff
Patch and updated layout tests (30.47 KB, text/plain) 2018-10-30 11:53 PDT, Zach Li	no flags	Details
Patch and updated layout tests (30.47 KB, patch) 2018-10-30 11:53 PDT, Zach Li	no flags	Details Formatted Diff Diff
Patch and updated layout tests (39.21 KB, patch) 2018-10-30 13:20 PDT, Zach Li	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Zach Li

Comment 1 2018-10-29 18:35:52 PDT

Created attachment 353340 [details] Patch

EWS Watchlist

Comment 2 2018-10-29 20:32:59 PDT

Comment on attachment 353340 [details] Patch Attachment 353340 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9774478 New failing tests: fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html

EWS Watchlist

Comment 3 2018-10-29 20:33:01 PDT

Created attachment 353351 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 4 2018-10-30 04:38:33 PDT

Comment on attachment 353340 [details] Patch Attachment 353340 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9777551 New failing tests: fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html

EWS Watchlist

Comment 5 2018-10-30 04:38:44 PDT

Created attachment 353360 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Zach Li

Comment 6 2018-10-30 11:20:44 PDT

Created attachment 353390 [details] Patch and updated layout tests

Zach Li

Comment 7 2018-10-30 11:21:33 PDT

rdar://problem/45657011

Zach Li

Comment 8 2018-10-30 11:53:14 PDT

Created attachment 353392 [details] Patch and updated layout tests

Zach Li

Comment 9 2018-10-30 11:53:53 PDT

Created attachment 353393 [details] Patch and updated layout tests

Zach Li

Comment 10 2018-10-30 13:20:28 PDT

Created attachment 353402 [details] Patch and updated layout tests

WebKit Commit Bot

Comment 11 2018-10-31 13:08:51 PDT

Comment on attachment 353402 [details] Patch and updated layout tests Clearing flags on attachment: 353402 Committed r237647: <https://trac.webkit.org/changeset/237647>

WebKit Commit Bot

Comment 12 2018-10-31 13:08:52 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.