Bug 191049

Summary:

Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category.

Product:

WebKit

Reporter:

dewei_zhu

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dewei_zhu, dino, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch	dino: review+

dewei_zhu

Reported 2018-10-29 16:44:45 PDT

Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category.

Attachments
Patch (1.35 KB, patch) 2018-10-29 16:45 PDT, dewei_zhu	no flags	Details Formatted Diff Diff
Patch for landing (1.35 KB, patch) 2018-10-29 16:50 PDT, dewei_zhu	no flags	Details Formatted Diff Diff
Patch (1.99 KB, patch) 2018-10-30 17:17 PDT, dewei_zhu	dino: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

dewei_zhu

Comment 1 2018-10-29 16:45:51 PDT

Created attachment 353333 [details] Patch

Chris Dumez

Comment 2 2018-10-29 16:48:07 PDT

Comment on attachment 353333 [details] Patch r=me

Chris Dumez

Comment 3 2018-10-29 16:49:29 PDT

Comment on attachment 353333 [details] Patch Clearing flags on attachment: 353333 Committed r237573: <https://trac.webkit.org/changeset/237573>

Chris Dumez

Comment 4 2018-10-29 16:49:30 PDT

All reviewed patches have been landed. Closing bug.

dewei_zhu

Comment 5 2018-10-29 16:50:08 PDT

Reopening to attach new patch.

dewei_zhu

Comment 6 2018-10-29 16:50:09 PDT

Created attachment 353334 [details] Patch for landing

Radar WebKit Bug Importer

Comment 7 2018-10-29 16:50:32 PDT

<rdar://problem/45654625>

WebKit Commit Bot

Comment 8 2018-10-29 16:51:39 PDT

Comment on attachment 353334 [details] Patch for landing Rejecting attachment 353334 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 353334, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=353334&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=191049&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 353334 from bug 191049. Fetching: https://bugs.webkit.org/attachment.cgi?id=353334 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/Shared/WebPreferences.yaml Hunk #1 FAILED at 1350. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/WebPreferences.yaml.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9773376

Chris Dumez

Comment 9 2018-10-29 16:53:26 PDT

I already landed it in https://trac.webkit.org/changeset/237573

Dean Jackson

Comment 10 2018-10-30 10:22:28 PDT

Comment on attachment 353334 [details] Patch for landing Could you also move the entire feature into the section with other experimental features? (A few lines above this)

dewei_zhu

Comment 11 2018-10-30 11:28:13 PDT

Will do in a followup fix.

dewei_zhu

Comment 12 2018-10-30 17:17:49 PDT

Reopening to attach new patch.

dewei_zhu

Comment 13 2018-10-30 17:17:50 PDT

Created attachment 353445 [details] Patch

Dean Jackson

Comment 14 2018-10-30 17:31:23 PDT

Comment on attachment 353445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353445&action=review > Source/WebKit/Shared/WebPreferences.yaml:1340 > +type: bool > +defaultValue: false > +humanReadableName: "Swap Processes on Cross-Site Navigation" > +humanReadableDescription: "Swap WebContent processes on cross-site navigations" > +category: experimental > +webcoreBinding: none Nit: indentation.

dewei_zhu

Comment 15 2018-10-30 17:34:19 PDT

Comment on attachment 353445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353445&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1340 >> +webcoreBinding: none > > Nit: indentation. Nice catch. Tricked by Xcode.

dewei_zhu

Comment 16 2018-10-30 17:38:19 PDT

Landed in r237611.

Note You need to log in before you can comment on or make changes to this bug.