Summary: | Enable InstallAPI for iOS unconditionally | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | WebKit Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, mitz, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=184225 | ||||||
Bug Depends on: | 191086 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Alexey Proskuryakov
2018-10-29 15:02:03 PDT
Created attachment 353326 [details]
proposed patch
Took the NSURLDownloadSPI trick from Dan's patch in bug 184225. (In reply to Alexey Proskuryakov from comment #2) > Took the NSURLDownloadSPI trick from Dan's patch in bug 184225. This doesn’t seem to include a crucial (at the time) bit of that patch. Namely, as it stands, this patch appears to have a public header (WebDownload.h) importing a private header (NSURLDownloadSPI.h). Not a problem? WebDownload.h appears to be a private header, am I missing something? WebDownload.h is re-exported by WebKit as public on macOS, which is fine. NSURLDownloadSPI.h is not imported on macOS. Comment on attachment 353326 [details] proposed patch Clearing flags on attachment: 353326 Committed r237600: <https://trac.webkit.org/changeset/237600> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 191086 Re-landed in https://trac.webkit.org/r237610. |