Bug 191031

Summary:

[GTK][WPE] Fixes to the PublicSuffix implementation

Product:

WebKit

Reporter:

Claudio Saavedra <csaavedra>

Component:

WebKitGTK

Assignee:

Claudio Saavedra <csaavedra>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bugs-noreply, chris.reid, commit-queue, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Claudio Saavedra 2018-10-29 09:08:52 PDT

[GTK][WPE] Fixes to the PublicSuffix implementation

Comment 1 Claudio Saavedra 2018-10-29 09:11:55 PDT

Created attachment 353291 [details]
Patch

Comment 2 Claudio Saavedra 2018-10-29 09:14:48 PDT

With this patch there are these two failures. I am not familiar with the r4--- prefix, is that something we should be able to decode or just noise?

../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:170
Expected equality of these values:
  String()
    Which is: 
  topPrivatelyControlledDomain("1")
    Which is: 1


../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:174
Expected equality of these values:
  String()
    Which is: 
  topPrivatelyControlledDomain("r4---asdf")
    Which is: r4---asdf

Comment 3 Claudio Saavedra 2018-10-29 09:15:51 PDT

NB: I am removing the test for 栃木.jp as it's a public-suffix and I don't think it should be tested where it currently is.

Comment 4 Michael Catanzaro 2018-10-29 11:38:55 PDT

(In reply to Claudio Saavedra from comment #2)
> With this patch there are these two failures. I am not familiar with the
> r4--- prefix, is that something we should be able to decode or just noise?

I don't know IDN. No clue.

Comment 5 WebKit Commit Bot 2018-10-30 01:27:04 PDT

Comment on attachment 353291 [details]
Patch

Clearing flags on attachment: 353291

Committed r237584: <https://trac.webkit.org/changeset/237584>

Comment 6 WebKit Commit Bot 2018-10-30 01:27:06 PDT

All reviewed patches have been landed.  Closing bug.