Summary: | [GTK][WPE] Fixes to the PublicSuffix implementation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> | ||||
Component: | WebKitGTK | Assignee: | Claudio Saavedra <csaavedra> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bugs-noreply, chris.reid, commit-queue, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Claudio Saavedra
2018-10-29 09:08:52 PDT
Created attachment 353291 [details]
Patch
With this patch there are these two failures. I am not familiar with the r4--- prefix, is that something we should be able to decode or just noise? ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:170 Expected equality of these values: String() Which is: topPrivatelyControlledDomain("1") Which is: 1 ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:174 Expected equality of these values: String() Which is: topPrivatelyControlledDomain("r4---asdf") Which is: r4---asdf NB: I am removing the test for 栃木.jp as it's a public-suffix and I don't think it should be tested where it currently is. (In reply to Claudio Saavedra from comment #2) > With this patch there are these two failures. I am not familiar with the > r4--- prefix, is that something we should be able to decode or just noise? I don't know IDN. No clue. Comment on attachment 353291 [details] Patch Clearing flags on attachment: 353291 Committed r237584: <https://trac.webkit.org/changeset/237584> All reviewed patches have been landed. Closing bug. |