Bug 191026

Summary: LibWebRTCRtpReceiverBackend::getSynchronizationSources should use Vector::append
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews105 for mac-sierra-wk2
none
Patch none

youenn fablet
Reported 2018-10-29 03:14:02 PDT
LibWebRTCRtpReceiverBackend::getSynchronizationSources should use Vector::append
Attachments
Patch (4.49 KB, patch)
2018-10-29 03:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.52 KB, patch)
2018-10-29 06:06 PDT, youenn fablet 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.03 MB, application/zip)
2018-10-29 07:17 PDT, EWS Watchlist 		no flags
Details
Patch (4.52 KB, patch)
2018-10-29 07:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-10-29 03:43:18 PDT
Created attachment 353281 [details] Patch
youenn fablet
Comment 2 2018-10-29 06:06:56 PDT
Created attachment 353284 [details] Patch
EWS Watchlist
Comment 3 2018-10-29 07:17:38 PDT
Comment on attachment 353284 [details] Patch Attachment 353284 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9767339 New failing tests: webrtc/video-addTransceiver.html
EWS Watchlist
Comment 4 2018-10-29 07:17:40 PDT
Created attachment 353287 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
youenn fablet
Comment 5 2018-10-29 07:45:53 PDT
Created attachment 353289 [details] Patch
Eric Carlson
Comment 6 2018-10-29 11:30:00 PDT
Comment on attachment 353289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353289&action=review > LayoutTests/webrtc/video-addTransceiver.html:114 > + if (sources.length) { Why do this test, shouldn't it be the same from run to run?
youenn fablet
Comment 7 2018-10-30 01:34:30 PDT
(In reply to Eric Carlson from comment #6) > Comment on attachment 353289 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353289&action=review > > > LayoutTests/webrtc/video-addTransceiver.html:114 > > + if (sources.length) { > > Why do this test, shouldn't it be the same from run to run? I get a consistent number of sources locally but not on bots. Slowness of bots probably affects gathering of the results.
WebKit Commit Bot
Comment 8 2018-10-30 01:59:53 PDT
Comment on attachment 353289 [details] Patch Clearing flags on attachment: 353289 Committed r237585: <https://trac.webkit.org/changeset/237585>
WebKit Commit Bot
Comment 9 2018-10-30 01:59:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-10-30 02:00:59 PDT
<rdar://problem/45663844>
Note You need to log in before you can comment on or make changes to this bug.