Bug 191026

Summary: LibWebRTCRtpReceiverBackend::getSynchronizationSources should use Vector::append
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews105 for mac-sierra-wk2
none
Patch none

Description youenn fablet 2018-10-29 03:14:02 PDT
LibWebRTCRtpReceiverBackend::getSynchronizationSources should use Vector::append
Comment 1 youenn fablet 2018-10-29 03:43:18 PDT
Created attachment 353281 [details]
Patch
Comment 2 youenn fablet 2018-10-29 06:06:56 PDT
Created attachment 353284 [details]
Patch
Comment 3 EWS Watchlist 2018-10-29 07:17:38 PDT
Comment on attachment 353284 [details]
Patch

Attachment 353284 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9767339

New failing tests:
webrtc/video-addTransceiver.html
Comment 4 EWS Watchlist 2018-10-29 07:17:40 PDT
Created attachment 353287 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 youenn fablet 2018-10-29 07:45:53 PDT
Created attachment 353289 [details]
Patch
Comment 6 Eric Carlson 2018-10-29 11:30:00 PDT
Comment on attachment 353289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353289&action=review

> LayoutTests/webrtc/video-addTransceiver.html:114
> +    if (sources.length) {

Why do this test, shouldn't it be the same from run to run?
Comment 7 youenn fablet 2018-10-30 01:34:30 PDT
(In reply to Eric Carlson from comment #6)
> Comment on attachment 353289 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353289&action=review
> 
> > LayoutTests/webrtc/video-addTransceiver.html:114
> > +    if (sources.length) {
> 
> Why do this test, shouldn't it be the same from run to run?

I get a consistent number of sources locally but not on bots.
Slowness of bots probably affects gathering of the results.
Comment 8 WebKit Commit Bot 2018-10-30 01:59:53 PDT
Comment on attachment 353289 [details]
Patch

Clearing flags on attachment: 353289

Committed r237585: <https://trac.webkit.org/changeset/237585>
Comment 9 WebKit Commit Bot 2018-10-30 01:59:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-10-30 02:00:59 PDT
<rdar://problem/45663844>