Bug 191015

Summary: [WPE] Add the WebKitVersion.h header
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-10-28 10:11:22 PDT
[WPE] Add the WebKitVersion.h header
Attachments
Patch (14.99 KB, patch)
2018-10-28 10:15 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.17 KB, patch)
2018-10-28 23:46 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-10-28 10:15:37 PDT
Created attachment 353260 [details] Patch
Zan Dobersek
Comment 2 2018-10-28 23:46:20 PDT
Created attachment 353275 [details] Patch for landing
Zan Dobersek
Comment 3 2018-10-28 23:48:37 PDT
Comment on attachment 353275 [details] Patch for landing Clearing flags on attachment: 353275 Committed r237541: <https://trac.webkit.org/changeset/237541>
Zan Dobersek
Comment 4 2018-10-28 23:48:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-10-29 13:32:58 PDT
<rdar://problem/45647211>
Radar WebKit Bug Importer
Comment 6 2018-10-29 13:33:03 PDT
<rdar://problem/45647216>
Philippe Normand
Comment 7 2018-11-03 05:36:55 PDT
The generated header is not installed. I fixed it locally with: diff --git a/Source/WebKit/PlatformWPE.cmake b/Source/WebKit/PlatformWPE.cmake index 6668d36c0eb..86095d1ac5f 100644 --- a/Source/WebKit/PlatformWPE.cmake +++ b/Source/WebKit/PlatformWPE.cmake @@ -93,6 +93,7 @@ list(APPEND WebKit_DERIVED_SOURCES set(WPE_API_INSTALLED_HEADERS ${DERIVED_SOURCES_WPE_API_DIR}/WebKitEnumTypes.h + ${DERIVED_SOURCES_WPE_API_DIR}/WebKitVersion.h ${WEBKIT_DIR}/UIProcess/API/wpe/WebKitApplicationInfo.h ${WEBKIT_DIR}/UIProcess/API/wpe/WebKitAuthenticationRequest.h ${WEBKIT_DIR}/UIProcess/API/wpe/WebKitAutomationSession.h r?
Michael Catanzaro
Comment 8 2018-11-03 07:09:09 PDT
Ooops. Yes, r=me.
Philippe Normand
Comment 9 2018-11-03 07:30:47 PDT
Committed r237772
Note You need to log in before you can comment on or make changes to this bug.