Bug 190993

Summary: Web Inspector: Table selection should not require that rows be in the cache
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 190100, 190299    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Archive of layout-test-results from ews116 for mac-sierra
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch
none
Patch none

Matt Baker
Reported 2018-10-27 13:15:18 PDT
.
Attachments
Patch (4.14 KB, patch)
2018-11-02 21:38 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.38 MB, application/zip)
2018-11-02 22:39 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews116 for mac-sierra (3.20 MB, application/zip)
2018-11-02 23:28 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.95 MB, application/zip)
2018-11-03 00:31 PDT, EWS Watchlist 		no flags
Details
Patch (5.01 KB, patch)
2018-11-03 10:32 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (4.21 KB, patch)
2018-11-04 15:24 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-10-27 13:15:47 PDT
<rdar://problem/45613812>
Matt Baker
Comment 2 2018-11-02 21:38:50 PDT
Created attachment 353760 [details] Patch
EWS Watchlist
Comment 3 2018-11-02 22:39:16 PDT
Comment on attachment 353760 [details] Patch Attachment 353760 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9841216 New failing tests: inspector/table/table-selection.html
EWS Watchlist
Comment 4 2018-11-02 22:39:18 PDT
Created attachment 353765 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 5 2018-11-02 23:28:53 PDT
Comment on attachment 353760 [details] Patch Attachment 353760 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9841350 New failing tests: inspector/table/table-selection.html
EWS Watchlist
Comment 6 2018-11-02 23:28:55 PDT
Created attachment 353768 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 7 2018-11-03 00:31:01 PDT
Comment on attachment 353760 [details] Patch Attachment 353760 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9842000 New failing tests: inspector/table/table-selection.html
EWS Watchlist
Comment 8 2018-11-03 00:31:03 PDT
Created attachment 353769 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Matt Baker
Comment 9 2018-11-03 10:32:13 PDT
Created attachment 353777 [details] Patch
Matt Baker
Comment 10 2018-11-04 15:24:41 PST
Created attachment 353810 [details] Patch
Devin Rousso
Comment 11 2018-11-05 10:35:51 PST
Comment on attachment 353810 [details] Patch r=me
WebKit Commit Bot
Comment 12 2018-11-05 11:01:38 PST
Comment on attachment 353810 [details] Patch Clearing flags on attachment: 353810 Committed r237817: <https://trac.webkit.org/changeset/237817>
WebKit Commit Bot
Comment 13 2018-11-05 11:01:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.