Bug 190989

Summary:

Web Inspector: refactor code for getting properties via WI.RemoteObject

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

190754

Attachments:

Description	Flags
Patch	none
Patch	none

Description Devin Rousso 2018-10-27 11:01:07 PDT

Provide a way for callers to retrieve properties on a `WI.RemoteObject` without generating a preview.  Additionally, centralize all the different functions into one main pathway.

Comment 1 Devin Rousso 2018-10-27 11:05:14 PDT

Created attachment 353239 [details]
Patch

Comment 2 EWS Watchlist 2018-10-27 11:09:13 PDT Comment hidden (obsolete)

Attachment 353239 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Devin Rousso 2018-10-27 11:11:41 PDT

Created attachment 353243 [details]
Patch

Whoops.  Forgot bug number.

Comment 4 Matt Baker 2018-10-29 16:04:20 PDT

Comment on attachment 353243 [details]
Patch

r=me

Comment 5 WebKit Commit Bot 2018-10-29 16:29:21 PDT

Comment on attachment 353243 [details]
Patch

Clearing flags on attachment: 353243

Committed r237571: <https://trac.webkit.org/changeset/237571>

Comment 6 WebKit Commit Bot 2018-10-29 16:29:23 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Radar WebKit Bug Importer 2018-10-29 16:30:45 PDT

<rdar://problem/45654001>