Bug 190986

Summary:

Web Inspector: refactor WI.ScopeBarItem for better extensibility

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

190754

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Devin Rousso

Reported 2018-10-27 10:59:35 PDT

This will allow options to be added in the future without having to supply falsy arguments.

Attachments
Patch (13.35 KB, patch) 2018-10-27 11:04 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (13.37 KB, patch) 2018-10-27 11:10 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (14.04 KB, patch) 2018-10-30 10:10 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2018-10-27 11:04:49 PDT

Created attachment 353238 [details] Patch

EWS Watchlist

Comment 2 2018-10-27 11:08:23 PDT Comment hidden (obsolete)

Attachment 353238 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Devin Rousso

Comment 3 2018-10-27 11:10:49 PDT

Created attachment 353242 [details] Patch Whoops. Forgot bug number.

Blaze Burg

Comment 4 2018-10-30 09:01:39 PDT

Comment on attachment 353242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353242&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + * UserInterface/Views/ScopeBarItem.js: You didn't say what the better extensibility is. > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:82 > + new WI.ScopeBarItem(WI.LogContentView.Scopes.Debugs, WI.UIString("Debugs"), {className: "debugs", hidden: true}), Yaaassss > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:58 > + exclusive: true, Nit: No need to wrap this line > Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:-155 > - var replacesCurrentSelection = this._shouldGroupNonExclusiveItems || !event.data.withModifier; Nit: let > Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:157 > + var replacesCurrentSelection = this._shouldGroupNonExclusiveItems || !event.data.extendSelection; You should mention this renaming in the changelog. I thought it was a mistake.

Devin Rousso

Comment 5 2018-10-30 10:10:32 PDT

Created attachment 353379 [details] Patch

WebKit Commit Bot

Comment 6 2018-10-30 10:48:25 PDT

Comment on attachment 353379 [details] Patch Clearing flags on attachment: 353379 Committed r237593: <https://trac.webkit.org/changeset/237593>

WebKit Commit Bot

Comment 7 2018-10-30 10:48:27 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2018-10-30 10:49:43 PDT

<rdar://problem/45673205>

Note You need to log in before you can comment on or make changes to this bug.