Summary: | Consider removing double load for accessing the instructions from LLInt | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tadeu Zagallo
2018-10-25 16:34:55 PDT
Created attachment 354567 [details]
Patch
Attachment 354567 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:373: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Ping? Ping? Comment on attachment 354567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354567&action=review > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1818 > - muli sizeof SimpleJumpTable, t3 # FIXME: would be nice to peephole this! > + muli sizeof SimpleJumpTable, t3 What's the peephole opportunity the comment was talking about, and is it invalid / inappropriate? What is your reason for this change? Comment on attachment 354567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354567&action=review >> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1818 >> + muli sizeof SimpleJumpTable, t3 > > What's the peephole opportunity the comment was talking about, and is it invalid / inappropriate? What is your reason for this change? This removal is because we already did this optimization in https://trac.webkit.org/changeset/237627/webkit. This comment means that we can perform strength reduction to convert `muli` to `lshifti` if `sizeof SimpleJumpTable` is a power of two. Comment on attachment 354567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354567&action=review r=me. >>> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1818 >>> + muli sizeof SimpleJumpTable, t3 >> >> What's the peephole opportunity the comment was talking about, and is it invalid / inappropriate? What is your reason for this change? > > This removal is because we already did this optimization in https://trac.webkit.org/changeset/237627/webkit. > This comment means that we can perform strength reduction to convert `muli` to `lshifti` if `sizeof SimpleJumpTable` is a power of two. OK, thanks. Committed r238367: <https://trac.webkit.org/changeset/238367> |