Bug 190901

Summary: [Web Animations] Turn Web Animations CSS Integration off by default
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, don.olmstead, ews-watchlist, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=190955
Attachments:
Description Flags
Patch
dino: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews113 for mac-sierra none

Antoine Quint
Reported 2018-10-25 08:18:44 PDT
[Web Animations] Turn Web Animations CSS Integration off by default
Attachments
Patch (5.71 KB, patch)
2018-10-25 08:19 PDT, Antoine Quint 		dino: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-sierra (3.06 MB, application/zip)
2018-10-25 10:26 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-10-25 08:19:31 PDT
Created attachment 353086 [details] Patch
Don Olmstead
Comment 2 2018-10-25 09:08:47 PDT
Informal r+. The WinCairo EWS is red because of https://bugs.webkit.org/show_bug.cgi?id=187725 which hopefully should be landing soon.
EWS Watchlist
Comment 3 2018-10-25 10:26:00 PDT
Comment on attachment 353086 [details] Patch Attachment 353086 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9726320 New failing tests: http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html
EWS Watchlist
Comment 4 2018-10-25 10:26:02 PDT
Created attachment 353091 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Antoine Quint
Comment 5 2018-10-25 12:17:12 PDT
Committed r237421: <https://trac.webkit.org/changeset/237421>
Radar WebKit Bug Importer
Comment 6 2018-10-25 12:18:34 PDT
<rdar://problem/45562620>
Ryan Haddad
Comment 7 2018-10-25 16:59:18 PDT
(In reply to Build Bot from comment #3) > Comment on attachment 353086 [details] > Patch > > Attachment 353086 [details] did not pass mac-debug-ews (mac): > Output: https://webkit-queues.webkit.org/results/9726320 > > New failing tests: > http/tests/inspector/network/resource-response-source-memory-cache- > revalidate-expired-only.html This is crashing on the bots now that this change has been landed. ASSERTION FAILED: !frame().animation().hasAnimations() ./page/FrameView.cpp(607) : void WebCore::FrameView::didDestroyRenderTree() https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r237421%20(342)/results.html
Antoine Quint
Comment 8 2018-10-26 01:59:37 PDT
The crash can be reproduced by running this command: run-webkit-tests -1 --debug --child-processes=1 http/tests/inspector/network/resource-initiatorNode.html http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html
Antoine Quint
Comment 9 2018-10-26 04:53:28 PDT
The reason this is happening is that RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsCSSIntegrationEnabled() is called under -[WebInspectorWindowController init:] with a value of false whereas this should always be true.
Antoine Quint
Comment 10 2018-10-26 05:49:28 PDT
The inspector test crash is tracked by https://bugs.webkit.org/show_bug.cgi?id=190955.
Note You need to log in before you can comment on or make changes to this bug.