Bug 190896

Summary:

Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, glenn, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2018-10-24 19:18:42 PDT

Add a watchlist message rule to warn about feature checking new inspector protocol changes So if someone adds: Page.newFeature We can add a comment that says "make sure to feature check new protocol APIs in the frontend".

Attachments
[PATCH] Proposed Fix (2.69 KB, patch) 2018-10-24 19:19 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2018-10-24 19:19:31 PDT

Created attachment 353071 [details] [PATCH] Proposed Fix

Matt Baker

Comment 2 2018-10-25 12:27:08 PDT

Comment on attachment 353071 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 3 2018-10-25 12:51:50 PDT

Comment on attachment 353071 [details] [PATCH] Proposed Fix Clearing flags on attachment: 353071 Committed r237422: <https://trac.webkit.org/changeset/237422>

WebKit Commit Bot

Comment 4 2018-10-25 12:51:51 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2018-10-25 12:52:39 PDT

<rdar://problem/45563601>

Note You need to log in before you can comment on or make changes to this bug.