Bug 19089

Summary:

Editing ASSERT in Range::compareBoundaryPoints

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

18858

Attachments:

Description	Flags
causes ASSERT in debug builds	none
patch	none
patch	eric: review+

Description Eric Seidel (no email) 2008-05-15 14:53:13 PDT

Editing ASSERT in Range::compareBoundaryPoints

ASSERTION FAILED: containerA && containerB
(/Users/eseidel/Projects/WebKit/WebCore/dom/Range.cpp:458 static short int WebCore::Range::compareBoundaryPoints(WebCore::Node*, int, WebCore::Node*, int))

Found by the fuzzer.  See attached test case.

  doc.execCommand('inserthorizontalrule');
  doc.execCommand('formatblock', 0, '<pre>');

Comment 1 Eric Seidel (no email) 2008-05-15 14:53:37 PDT

Created attachment 21182 [details]
causes ASSERT in debug builds

Comment 2 Justin Garcia 2008-06-05 16:59:54 PDT

Created attachment 21514 [details]
patch

Comment 3 Justin Garcia 2008-06-05 17:03:50 PDT

Created attachment 21515 [details]
patch

Didn't include the meat of the patch last time.

Comment 4 Eric Seidel (no email) 2008-06-05 17:13:03 PDT

Comment on attachment 21515 [details]
patch

Looks good to me.  r+

Comment 5 Justin Garcia 2008-06-05 17:22:12 PDT

http://trac.webkit.org/changeset/34390