Bug 190885

Summary: [High Sierra / Mojave Debug WK2] Layout Test media/video-restricted-invisible-autoplay-allowed-when-visible.html is a flaky failure
Product: WebKit Reporter: Dawei Fenton (:realdawei) <realdawei>
Component: Tools / TestsAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric.carlson, jer.noble, jlewis3, lforschler, ryanhaddad, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dawei Fenton (:realdawei)
Reported 2018-10-24 11:37:15 PDT
The following layout test is failing on [High Sierra Debug WK2] media/video-restricted-invisible-autoplay-allowed-when-visible.html Probable cause: Unknown Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-restricted-invisible-autoplay-allowed-when-visible.html --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/video-restricted-invisible-autoplay-allowed-when-visible-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/video-restricted-invisible-autoplay-allowed-when-visible-actual.txt @@ -3,6 +3,6 @@ RUN(internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted")) ** setting video.src RUN(document.body.appendChild(video)) -EVENT(play) +FAIL: did not end fast enough END OF TEST
Attachments
Patch (1.56 KB, patch)
2019-06-12 16:28 PDT, Eric Carlson
no flags
Ryan Haddad
Comment 1 2018-10-25 09:31:05 PDT
I can repro the failures locally with: media/video-restricted-invisible-autoplay-allowed-when-visible.html -fg --iter 100 --no-retry I cannot repro the failure after making this change: diff --git a/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html b/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html index 50b7a1a7d88..a09825fb1a7 100644 --- a/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html +++ b/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html @@ -19,7 +19,7 @@ function putInDOM() { run('document.body.appendChild(video)'); - failTestIn(250); + failTestIn(2000); } function play()
Radar WebKit Bug Importer
Comment 2 2018-10-26 09:54:59 PDT
Eric Carlson
Comment 3 2019-06-12 16:28:53 PDT
WebKit Commit Bot
Comment 4 2019-06-12 17:02:22 PDT
Comment on attachment 371999 [details] Patch Clearing flags on attachment: 371999 Committed r246387: <https://trac.webkit.org/changeset/246387>
WebKit Commit Bot
Comment 5 2019-06-12 17:02:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.