Summary: | Web Inspector: popovers for function source code are malformed | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Devin Rousso
2018-10-23 19:22:02 PDT
Created attachment 353016 [details]
Patch
Comment on attachment 353016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353016&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Popover.js:373 > + this._animationFrameIdentifier = requestAnimationFrame(drawBackground.bind(this)); Can we add this to the constructor? I like to have all member variables defined there when possible. this._animationFrameIdentifier = undefined; > Source/WebInspectorUI/UserInterface/Views/Popover.js:381 > + cancelAnimationFrame(this._animationFrameIdentifier); Preferably this would also clear the identifier: this._animationFrameIdentifier = undefined; Created attachment 353051 [details]
Patch
Comment on attachment 353051 [details] Patch Clearing flags on attachment: 353051 Committed r237401: <https://trac.webkit.org/changeset/237401> All reviewed patches have been landed. Closing bug. |