Bug 190846

Summary: [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, dbates, ews-watchlist, ggaren, japhet, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

Description Chris Dumez 2018-10-23 16:43:57 PDT 
When navigating back and forth, 'about:blank' shows up in the back/forward list.
Comment 1 Chris Dumez 2018-10-23 16:44:22 PDT 
<rdar://problem/45058938>
Comment 2 Chris Dumez 2018-10-23 16:55:44 PDT 
Created attachment 353006 [details]
Patch
Comment 3 Chris Dumez 2018-10-23 17:31:43 PDT 
Comment on attachment 353006 [details]
Patch

Might have a better idea. Will try it out first.
Comment 4 Chris Dumez 2018-10-23 19:38:02 PDT 
Created attachment 353018 [details]
Patch
Comment 5 Antti Koivisto 2018-10-24 09:30:00 PDT 
Comment on attachment 353018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353018&action=review

> Source/WebCore/loader/FrameLoader.cpp:3368
> +        if (shouldContinue == ShouldContinue::ForSuspension) {
> +            m_loadType = FrameLoadType::Standard;
>              m_provisionalDocumentLoader->willContinueMainResourceLoadAfterRedirect({ blankURL() });

Might be good to add a comment explaining why the load type is set to Standard.
Comment 6 Chris Dumez 2018-10-24 09:39:25 PDT 
Committed r237386: <https://trac.webkit.org/changeset/237386>