Bug 190830

Summary: ASSERTION FAILED: !needsLayout() in media/track/video-track-addition-and-frame-removal.html
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: ap, bfulgham, eric.carlson, jacob_uphoff, jer.noble, jlewis3, lforschler, realdawei, rniwa, ryanhaddad, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update Test Expectations none

Truitt Savell
Reported 2018-10-23 08:50:32 PDT
The following layout test is failing on Mojave Debug WK1 media/track/video-track-addition-and-frame-removal.html Probable cause: Unknown, crash has been occurring for the whole history. Test is hitting an assertion Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Fvideo-track-addition-and-frame-removal.html Log: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r237349%20(308)/media/track/video-track-addition-and-frame-removal-crash-log.txt Excerpt: Application Specific Information: CRASHING TEST: media/track/video-track-addition-and-frame-removal.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010fbc0030 WTFCrash + 16 (Assertions.cpp:255) 1 com.apple.WebCore 0x000000011e3a6afb WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x0000000120eb501a WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy) + 602 (FrameView.cpp:4155) 3 com.apple.WebKitLegacy 0x0000000116431e5e -[WebFrame(WebInternal) _drawRect:contentsOnly:] + 1342 (WebFrame.mm:665)
Attachments
Update Test Expectations (1.40 KB, patch)
2020-01-28 11:25 PST, Jacob Uphoff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-10-25 10:13:32 PDT
ASSERTION FAILED: !needsLayout() ./page/FrameView.cpp(4155) : virtual void WebCore::FrameView::paintContents(WebCore::GraphicsContext &, const WebCore::IntRect &, WebCore::Widget::SecurityOriginPaintPolicy) We have multiple bugs about this assertion failing, but I don't know how to tell which ones are dupes.
Alexey Proskuryakov
Comment 2 2020-01-26 12:14:12 PST
*** Bug 206714 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 3 2020-01-26 12:14:40 PST
<rdar://problem/58853165>
Jacob Uphoff
Comment 4 2020-01-28 11:25:38 PST
Created attachment 389039 [details] Update Test Expectations
Truitt Savell
Comment 5 2020-01-28 11:28:45 PST
Comment on attachment 389039 [details] Update Test Expectations Clearing flags on attachment: 389039 Committed r255266: <https://trac.webkit.org/changeset/255266>
Simon Fraser (smfr)
Comment 6 2020-01-28 13:26:19 PST
This only asserts in WK1. Please adjust the expectations accordingly.
Simon Fraser (smfr)
Comment 7 2020-01-28 13:26:36 PST
Oh nm, you did.
Note You need to log in before you can comment on or make changes to this bug.