Bug 190808

Summary: Layout Test imported/w3c/web-platform-tests/intersection-observer/containing-block.html is a flaky failure on Debug builds
Product: WebKit Reporter: Ali Juma <ajuma>
Component: Tools / TestsAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, lforschler, rohitrao, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Suppress flaky test
none
Patch none

Ali Juma
Reported 2018-10-22 14:51:47 PDT
It looks like the fix to bug 189091 reduced overall flakiness but containing-block.html is still flaky on Debug.
Attachments
Suppress flaky test (1.54 KB, patch)
2018-10-22 15:00 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Patch (2.24 KB, patch)
2019-05-14 13:34 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-10-22 15:00:45 PDT
Created attachment 352912 [details] Suppress flaky test
Ali Juma
Comment 2 2018-10-22 15:02:54 PDT
Comment on attachment 352912 [details] Suppress flaky test Clearing flags on attachment: 352912 Committed r237334: <https://trac.webkit.org/changeset/237334>
EWS Watchlist
Comment 3 2018-10-22 15:03:42 PDT
Attachment 352912 [details] did not pass style-queue: ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:2848: Duplicate or ambiguous entry lines LayoutTests/TestExpectations:2846 and LayoutTests/TestExpectations:2848. [test/expectations] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ali Juma
Comment 4 2019-05-14 13:34:27 PDT
Created attachment 369888 [details] Patch
Ali Juma
Comment 5 2019-05-14 13:36:33 PDT
This test (and other IntersectionObserver tests that were flaky on Mac Debug) is no longer flaky after recent changes to rAF timing that align behavior with the spec and with other browsers.
Ali Juma
Comment 6 2019-05-14 13:38:50 PDT
Comment on attachment 369888 [details] Patch Clearing flags on attachment: 369888 Committed r245304: <https://trac.webkit.org/changeset/245304>
Ali Juma
Comment 7 2019-05-14 13:38:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-05-14 13:40:55 PDT
<rdar://problem/50780712>
Note You need to log in before you can comment on or make changes to this bug.