Summary: | Layout Test imported/w3c/web-platform-tests/intersection-observer/containing-block.html is a flaky failure on Debug builds | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ali Juma <ajuma> | ||||||
Component: | Tools / Tests | Assignee: | Ali Juma <ajuma> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, lforschler, rohitrao, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ali Juma
2018-10-22 14:51:47 PDT
Created attachment 352912 [details]
Suppress flaky test
Comment on attachment 352912 [details] Suppress flaky test Clearing flags on attachment: 352912 Committed r237334: <https://trac.webkit.org/changeset/237334> Attachment 352912 [details] did not pass style-queue:
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:2848: Duplicate or ambiguous entry lines LayoutTests/TestExpectations:2846 and LayoutTests/TestExpectations:2848. [test/expectations] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 369888 [details]
Patch
This test (and other IntersectionObserver tests that were flaky on Mac Debug) is no longer flaky after recent changes to rAF timing that align behavior with the spec and with other browsers. Comment on attachment 369888 [details] Patch Clearing flags on attachment: 369888 Committed r245304: <https://trac.webkit.org/changeset/245304> All reviewed patches have been landed. Closing bug. |