Bug 190808 - Layout Test imported/w3c/web-platform-tests/intersection-observer/containing-block.html is a flaky failure on Debug builds
Summary: Layout Test imported/w3c/web-platform-tests/intersection-observer/containing-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-22 14:51 PDT by Ali Juma
Modified: 2019-05-14 13:40 PDT (History)
4 users (show)

See Also:


Attachments
Suppress flaky test (1.54 KB, patch)
2018-10-22 15:00 PDT, Ali Juma
no flags Details | Formatted Diff | Diff
Patch (2.24 KB, patch)
2019-05-14 13:34 PDT, Ali Juma
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-10-22 14:51:47 PDT
It looks like the fix to bug 189091 reduced overall flakiness but containing-block.html is still flaky on Debug.
Comment 1 Ali Juma 2018-10-22 15:00:45 PDT
Created attachment 352912 [details]
Suppress flaky test
Comment 2 Ali Juma 2018-10-22 15:02:54 PDT
Comment on attachment 352912 [details]
Suppress flaky test

Clearing flags on attachment: 352912

Committed r237334: <https://trac.webkit.org/changeset/237334>
Comment 3 EWS Watchlist 2018-10-22 15:03:42 PDT
Attachment 352912 [details] did not pass style-queue:


ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:2848:  Duplicate or ambiguous entry lines LayoutTests/TestExpectations:2846 and LayoutTests/TestExpectations:2848.  [test/expectations] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ali Juma 2019-05-14 13:34:27 PDT
Created attachment 369888 [details]
Patch
Comment 5 Ali Juma 2019-05-14 13:36:33 PDT
This test (and other IntersectionObserver tests that were flaky on Mac Debug) is no longer flaky after recent changes to rAF timing that align behavior with the spec and with other browsers.
Comment 6 Ali Juma 2019-05-14 13:38:50 PDT
Comment on attachment 369888 [details]
Patch

Clearing flags on attachment: 369888

Committed r245304: <https://trac.webkit.org/changeset/245304>
Comment 7 Ali Juma 2019-05-14 13:38:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-05-14 13:40:55 PDT
<rdar://problem/50780712>