Summary: | Deque's contains() and findIf() should be const | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, aestes, benjamin, cmarcelo, commit-queue, dbates, ews-watchlist, ggaren, koivisto, rniwa, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2018-10-22 09:39:02 PDT
Created attachment 352895 [details]
Patch
Comment on attachment 352895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review > Source/WTF/wtf/Deque.h:407 > + return std::find_if(begin(), end(), predicate); Considering how few clients this stuff has, maybe they could just do this themselves. Comment on attachment 352895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review >> Source/WTF/wtf/Deque.h:407 >> + return std::find_if(begin(), end(), predicate); > > Considering how few clients this stuff has, maybe they could just do this themselves. I considered that but I personally do not like the std::algorithm functions as they are too verbose. I like that our container types have their own less verbose convenience methods. Comment on attachment 352895 [details] Patch Clearing flags on attachment: 352895 Committed r237329: <https://trac.webkit.org/changeset/237329> All reviewed patches have been landed. Closing bug. |