Bug 190796 – Deque's contains() and findIf() should be const

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Chris Dumez]

Deque's contains() and findIf() should be const as they do not modify the container.

[Chris Dumez]

Created attachment 352895 [details]
Patch

[Antti Koivisto]

Comment on attachment 352895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review

> Source/WTF/wtf/Deque.h:407
> +    return std::find_if(begin(), end(), predicate);

Considering how few clients this stuff has, maybe they could just do this themselves.

[Chris Dumez]

Comment on attachment 352895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review

>> Source/WTF/wtf/Deque.h:407
>> +    return std::find_if(begin(), end(), predicate);
> 
> Considering how few clients this stuff has, maybe they could just do this themselves.

I considered that but I personally do not like the std::algorithm functions as they are too verbose. I like that our container types have their own less verbose convenience methods.

[WebKit Commit Bot]

Comment on attachment 352895 [details]
Patch

Clearing flags on attachment: 352895

Committed r237329: <https://trac.webkit.org/changeset/237329>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45465502>