Summary: | Style queue exception on some security bugs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dbates, ews-watchlist, glenn, lforschler, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=169275 | ||||||||
Attachments: |
|
Description
Aakash Jain
2018-10-22 06:55:14 PDT
This has been happening multiple times daily. [~] grep "object has no attribute" *.log style-queue_2018-11-06_04-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-11-06_04-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-11-06_04-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-11-06_04-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-11-06_10-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-11-06_10-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-11-06_10-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-11-06_10-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' ... ... style-queue_2018-12-05_17-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-06_01-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-06_01-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-06_09-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-06_09-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-06_09-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-06_16-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-06_16-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-07_00-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-07_00-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' style-queue_2018-12-07_00-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails' Created attachment 356788 [details]
Proposed patch
Attachment 356788 [details] did not pass style-queue:
ERROR: Tools/ChangeLog:3: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 356788 [details] Proposed patch Attachment 356788 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10302526 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html Created attachment 356795 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 356788 [details] Proposed patch Clearing flags on attachment: 356788 Committed r238956: <https://trac.webkit.org/changeset/238956> All reviewed patches have been landed. Closing bug. |