| Summary: | Use WeakPtr and GenericTaskQueue within ObjC classes used by MediaPlayerPrivateAVFoundationObjC | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, eric.carlson, ews-watchlist, ryanhaddad, tsavell, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Jer Noble
2018-10-22 03:16:05 PDT
Created attachment 352883 [details]
Patch
Created attachment 352886 [details]
Patch
Comment on attachment 352886 [details] Patch Attachment 352886 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9693492 New failing tests: webanimations/leak-document-with-web-animation.html Created attachment 352889 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 352886 [details] Patch Attachment 352886 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9693479 New failing tests: inspector/console/webcore-logging.html media/video-src-blob-using-open-panel.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html media/sources-fallback-codecs.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/media-source/mediasource-detach.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html media/audio-data-url.html http/tests/media/clearkey/clear-key-hls-aes128.html http/tests/media/clearkey/collect-webkit-media-session.html media/video-src-blob.html media/unsupported-rtsp.html imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html fast/forms/form-associated-element-crash3.html Created attachment 352891 [details]
Archive of layout-test-results from ews112 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 352886 [details] Patch Attachment 352886 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9694291 New failing tests: inspector/console/webcore-logging.html media/video-src-blob-using-open-panel.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html media/sources-fallback-codecs.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/media-source/mediasource-detach.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html media/audio-data-url.html http/tests/media/clearkey/clear-key-hls-aes128.html http/tests/media/clearkey/collect-webkit-media-session.html media/video-src-blob.html media/unsupported-rtsp.html imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html fast/forms/form-associated-element-crash3.html Created attachment 352894 [details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 352968 [details]
Patch for landing
Comment on attachment 352968 [details] Patch for landing Clearing flags on attachment: 352968 Committed r237350: <https://trac.webkit.org/changeset/237350> All reviewed patches have been landed. Closing bug. It looks like the changes in https://trac.webkit.org/changeset/237350/webkit has caused a crash in security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=security%2FcontentSecurityPolicy%2Fvideo-with-data-url-allowed-by-media-src-star.html Crash: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r237350%20(6087)/security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star-crash-log.txt I reproduced this Crash using: run-webkit-tests --root debug-237350 security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html --iterations 500 -f --debug -1 no crash will occur on a debug build of 237349. found two additional crashes that this may be related to: imported/w3c/web-platform-tests/media-source/mediasource-preload.html inspector/console/webcore-logging.html History https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fconsole%2Fwebcore-logging.html%20imported%2Fw3c%2Fweb-platform-tests%2Fmedia-source%2Fmediasource-preload.html Logs: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r237352%20(8393)/imported/w3c/web-platform-tests/media-source/mediasource-preload-crash-log.txt https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r237352%20(8393)/inspector/console/webcore-logging-crash-log.txt Reverted r237350 for reason: Caused several Crashes cross multiple tests and platforms. Committed r237364: <https://trac.webkit.org/changeset/237364> *** Bug 190837 has been marked as a duplicate of this bug. *** (In reply to Truitt Savell from comment #15) > Reverted r237350 for reason: > > Caused several Crashes cross multiple tests and platforms. > > Committed r237364: <https://trac.webkit.org/changeset/237364> Looks like this is due to a stray ASSERT that is no longer relevant. Will post new patch. Created attachment 353024 [details]
Patch for landing
Committed r237378: <https://trac.webkit.org/changeset/237378> |