Bug 190790

Summary:

Use WeakPtr and GenericTaskQueue within ObjC classes used by MediaPlayerPrivateAVFoundationObjC

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, eric.carlson, ews-watchlist, ryanhaddad, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews204 for win-future	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews115 for mac-sierra	none
Patch for landing	none
Patch for landing	none

Jer Noble

Reported 2018-10-22 03:16:05 PDT

Use WeakPtr and GenericTaskQueue within ObjC classes used by MediaPlayerPrivateAVFoundationObjC

Attachments
Patch (30.54 KB, patch) 2018-10-22 03:27 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (30.64 KB, patch) 2018-10-22 05:08 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (12.71 MB, application/zip) 2018-10-22 07:02 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (3.94 MB, application/zip) 2018-10-22 07:25 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (3.94 MB, application/zip) 2018-10-22 09:29 PDT, EWS Watchlist	no flags	Details
Patch for landing (31.10 KB, patch) 2018-10-23 04:32 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (31.05 KB, patch) 2018-10-23 23:50 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2018-10-22 03:27:13 PDT

Created attachment 352883 [details] Patch

Jer Noble

Comment 2 2018-10-22 05:08:59 PDT

Created attachment 352886 [details] Patch

EWS Watchlist

Comment 3 2018-10-22 07:02:24 PDT

Comment on attachment 352886 [details] Patch Attachment 352886 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9693492 New failing tests: webanimations/leak-document-with-web-animation.html

EWS Watchlist

Comment 4 2018-10-22 07:02:36 PDT

Created attachment 352889 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

EWS Watchlist

Comment 5 2018-10-22 07:25:18 PDT

Comment on attachment 352886 [details] Patch Attachment 352886 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9693479 New failing tests: inspector/console/webcore-logging.html media/video-src-blob-using-open-panel.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html media/sources-fallback-codecs.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/media-source/mediasource-detach.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html media/audio-data-url.html http/tests/media/clearkey/clear-key-hls-aes128.html http/tests/media/clearkey/collect-webkit-media-session.html media/video-src-blob.html media/unsupported-rtsp.html imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html fast/forms/form-associated-element-crash3.html

EWS Watchlist

Comment 6 2018-10-22 07:25:20 PDT

Created attachment 352891 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-10-22 09:29:46 PDT

Comment on attachment 352886 [details] Patch Attachment 352886 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9694291 New failing tests: inspector/console/webcore-logging.html media/video-src-blob-using-open-panel.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html media/sources-fallback-codecs.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/media-source/mediasource-detach.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html media/audio-data-url.html http/tests/media/clearkey/clear-key-hls-aes128.html http/tests/media/clearkey/collect-webkit-media-session.html media/video-src-blob.html media/unsupported-rtsp.html imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html fast/forms/form-associated-element-crash3.html

EWS Watchlist

Comment 8 2018-10-22 09:29:48 PDT

Created attachment 352894 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

Jer Noble

Comment 9 2018-10-23 04:32:19 PDT

Created attachment 352968 [details] Patch for landing

WebKit Commit Bot

Comment 10 2018-10-23 07:41:05 PDT

Comment on attachment 352968 [details] Patch for landing Clearing flags on attachment: 352968 Committed r237350: <https://trac.webkit.org/changeset/237350>

WebKit Commit Bot

Comment 11 2018-10-23 07:41:07 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2018-10-23 07:42:37 PDT

<rdar://problem/45487049>

Truitt Savell

Comment 13 2018-10-23 11:29:43 PDT

It looks like the changes in https://trac.webkit.org/changeset/237350/webkit has caused a crash in security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=security%2FcontentSecurityPolicy%2Fvideo-with-data-url-allowed-by-media-src-star.html Crash: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r237350%20(6087)/security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star-crash-log.txt I reproduced this Crash using: run-webkit-tests --root debug-237350 security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html --iterations 500 -f --debug -1 no crash will occur on a debug build of 237349.

Truitt Savell

Comment 14 2018-10-23 13:00:39 PDT

found two additional crashes that this may be related to: imported/w3c/web-platform-tests/media-source/mediasource-preload.html inspector/console/webcore-logging.html History https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fconsole%2Fwebcore-logging.html%20imported%2Fw3c%2Fweb-platform-tests%2Fmedia-source%2Fmediasource-preload.html Logs: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r237352%20(8393)/imported/w3c/web-platform-tests/media-source/mediasource-preload-crash-log.txt https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r237352%20(8393)/inspector/console/webcore-logging-crash-log.txt

Truitt Savell

Comment 15 2018-10-23 13:02:57 PDT

Reverted r237350 for reason: Caused several Crashes cross multiple tests and platforms. Committed r237364: <https://trac.webkit.org/changeset/237364>

Ryan Haddad

Comment 16 2018-10-23 13:05:39 PDT

*** Bug 190837 has been marked as a duplicate of this bug. ***

Jer Noble

Comment 17 2018-10-23 23:41:50 PDT

(In reply to Truitt Savell from comment #15) > Reverted r237350 for reason: > > Caused several Crashes cross multiple tests and platforms. > > Committed r237364: <https://trac.webkit.org/changeset/237364> Looks like this is due to a stray ASSERT that is no longer relevant. Will post new patch.

Jer Noble

Comment 18 2018-10-23 23:50:14 PDT

Created attachment 353024 [details] Patch for landing

Jer Noble

Comment 19 2018-10-24 03:03:47 PDT

Committed r237378: <https://trac.webkit.org/changeset/237378>

Note You need to log in before you can comment on or make changes to this bug.