Bug 190739

Summary: Add test expectations for webgpu-enabled.html
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Justin Fan
Reported 2018-10-18 15:50:43 PDT
Add test expectations for webgpu-enabled.html
Attachments
Patch (1.09 KB, patch)
2018-10-18 15:53 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (4.45 KB, patch)
2018-10-18 16:28 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (5.12 KB, patch)
2018-10-18 19:04 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2018-10-18 15:53:25 PDT
Created attachment 352742 [details] Patch
Ryan Haddad
Comment 2 2018-10-18 16:04:35 PDT
Should the test be skipped on WK1? It looks like the results there are different: CONSOLE MESSAGE: line 11: TypeError: undefined is not an object (evaluating 'window.webgpu.requestAdapter') FAIL undefined should be defined. Was undefined FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). TEST COMPLETE https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r237266%20(401)/results.html
Justin Fan
Comment 3 2018-10-18 16:28:17 PDT
Created attachment 352745 [details] Patch
Justin Fan
Comment 4 2018-10-18 16:28:58 PDT
(In reply to Ryan Haddad from comment #2) > Should the test be skipped on WK1? It looks like the results there are > different: > > CONSOLE MESSAGE: line 11: TypeError: undefined is not an object (evaluating > 'window.webgpu.requestAdapter') > FAIL undefined should be defined. Was undefined > FAIL successfullyParsed should be true (of type boolean). Was undefined (of > type undefined). > > TEST COMPLETE > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/ > r237266%20(401)/results.html Thanks for the catch. Updated some test expectations to match.
Justin Fan
Comment 5 2018-10-18 19:04:48 PDT
Created attachment 352754 [details] Patch
WebKit Commit Bot
Comment 6 2018-10-18 20:54:58 PDT
Comment on attachment 352754 [details] Patch Clearing flags on attachment: 352754 Committed r237279: <https://trac.webkit.org/changeset/237279>
WebKit Commit Bot
Comment 7 2018-10-18 20:54:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-10-18 20:55:29 PDT
<rdar://problem/45394807>
Note You need to log in before you can comment on or make changes to this bug.