Bug 190731

Summary: Clean up FrameLoader two-state enums
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch cdumez: review+

Description Alex Christensen 2018-10-18 13:41:20 PDT
Clean up FrameLoader two-state enums
Comment 1 Alex Christensen 2018-10-18 13:51:20 PDT
Created attachment 352726 [details]
Comment 2 EWS Watchlist 2018-10-18 13:54:32 PDT
Attachment 352726 [details] did not pass style-queue:

ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:78:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 27 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2018-10-18 14:17:07 PDT
Comment 4 Radar WebKit Bug Importer 2018-10-18 14:18:41 PDT