Bug 190730

Summary: [WebVTT] The TextTrackLoader parameter in TextTrackLoaderClient virtual methods should be a reference
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, calvaris, cdumez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, philipj, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2018-10-18 13:37:19 PDT
It is currently a pointer.
Attachments
Patch (5.27 KB, patch)
2018-10-18 13:39 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-10-18 13:38:06 PDT
<rdar://problem/45382278>
Per Arne Vollan
Comment 2 2018-10-18 13:39:37 PDT
Created attachment 352725 [details] Patch
Chris Dumez
Comment 3 2018-10-18 13:44:32 PDT
Comment on attachment 352725 [details] Patch r=me if the bots are happy.
Per Arne Vollan
Comment 4 2018-10-18 13:54:18 PDT
Comment on attachment 352725 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 5 2018-10-18 14:30:36 PDT
Comment on attachment 352725 [details] Patch Clearing flags on attachment: 352725 Committed r237265: <https://trac.webkit.org/changeset/237265>
WebKit Commit Bot
Comment 6 2018-10-18 14:30:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.