Bug 190711

Summary: [GTK] fast/selectors/read-only-read-write-input-basics.html failing since r237245 - Enable the datalist element by default on iOS and macOS
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
none
Patch for EWS none

Miguel Gomez
Reported 2018-10-18 08:05:32 PDT
fast/selectors/read-only-read-write-input-basics.html [ Failure ] The diff is quite bit, can be seen here https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r237249%20(8526)/fast/selectors/read-only-read-write-input-basics-pretty-diff.html The test was update in the bug, and the Apple ports have custom expectations for their ports. Not sure we should add our own or if this is really a bug.
Attachments
Patch for EWS (149.42 KB, patch)
2018-10-18 08:27 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for EWS (567.12 KB, patch)
2018-10-18 08:40 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-10-18 08:16:18 PDT
I think we should restore the baseline (fast/selectors/read-only-read-write-input-basics-expected.txt) to what it was prior to r237245.
Wenson Hsieh
Comment 2 2018-10-18 08:27:48 PDT
Created attachment 352691 [details] Patch for EWS
Wenson Hsieh
Comment 3 2018-10-18 08:40:31 PDT
Created attachment 352693 [details] Patch for EWS
WebKit Commit Bot
Comment 4 2018-10-18 10:12:07 PDT
Comment on attachment 352693 [details] Patch for EWS Clearing flags on attachment: 352693 Committed r237258: <https://trac.webkit.org/changeset/237258>
WebKit Commit Bot
Comment 5 2018-10-18 10:12:08 PDT
All reviewed patches have been landed. Closing bug.
Wenson Hsieh
Comment 6 2018-10-18 10:13:13 PDT
(In reply to Miguel Gomez from comment #0) > fast/selectors/read-only-read-write-input-basics.html [ Failure ] > > The diff is quite bit, can be seen here > > https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/ > r237249%20(8526)/fast/selectors/read-only-read-write-input-basics-pretty- > diff.html > > The test was update in the bug, and the Apple ports have custom expectations > for their ports. Not sure we should add our own or if this is really a bug. Please let me know whether the rebaselining fixes the test failures you're seeing!
Michael Catanzaro
Comment 7 2018-10-27 18:54:00 PDT
Confirming fast/selectors/read-only-read-write-input-basics.html is fixed. Removing the failure expectation. Thanks Wenson!
Note You need to log in before you can comment on or make changes to this bug.