Bug 190694

Summary: AI does not clear Phantom allocation nodes.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Keith Miller
Reported 2018-10-17 17:38:09 PDT
AI does not clear Phantom allocation nodes.
Attachments
Patch (5.24 KB, patch)
2018-10-17 17:40 PDT, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-10-17 17:40:01 PDT
Created attachment 352667 [details] Patch
Saam Barati
Comment 2 2018-10-17 17:41:51 PDT
Comment on attachment 352667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352667&action=review r=me > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2578 > // This claims to return bottom. nit: IMO We don't really need this comment anymore since it just says exactly what the code is doing.
Keith Miller
Comment 3 2018-10-17 17:44:30 PDT
Comment on attachment 352667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352667&action=review >> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2578 >> // This claims to return bottom. > > nit: IMO We don't really need this comment anymore since it just says exactly what the code is doing. Fair enough, I'll remove.
Keith Miller
Comment 4 2018-10-17 20:18:15 PDT
Committed r237244: <https://trac.webkit.org/changeset/237244>
Keith Miller
Comment 5 2018-10-17 20:18:51 PDT
rdar://problem/45218452
Radar WebKit Bug Importer
Comment 6 2018-10-17 20:19:22 PDT
<rdar://problem/45360871>
Mark Lam
Comment 7 2018-10-17 21:28:40 PDT
<rdar://problem/45218452>
Note You need to log in before you can comment on or make changes to this bug.