Bug 190681

Summary: Handle MDNS resolution of candidates through libwebrtc directly
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2018-10-17 12:48:39 PDT 
Libwebrtc has proper support for MDNS name resolution.
Let's use that.
Comment 1 youenn fablet 2018-10-17 13:49:17 PDT 
Created attachment 352633 [details]
Patch
Comment 2 WebKit Commit Bot 2018-10-18 11:15:26 PDT 
Comment on attachment 352633 [details]
Patch

Clearing flags on attachment: 352633

Committed r237261: <https://trac.webkit.org/changeset/237261>
Comment 3 WebKit Commit Bot 2018-10-18 11:15:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-10-18 11:16:24 PDT 
<rdar://problem/45377118>
Comment 5 Ryan Haddad 2018-10-23 14:07:20 PDT 
Reverted r237261 for reason:

The layout test for this change crashes under GuardMalloc.

Committed r237367: <https://trac.webkit.org/changeset/237367>
Comment 6 Ryan Haddad 2018-10-23 14:07:53 PDT 
(In reply to Ryan Haddad from comment #5)
> Reverted r237261 for reason:
> 
> The layout test for this change crashes under GuardMalloc.
> 
> Committed r237367: <https://trac.webkit.org/changeset/237367>
Details in radar.
Comment 7 youenn fablet 2018-10-29 07:37:01 PDT 
Created attachment 353288 [details]
Patch
Comment 8 Eric Carlson 2018-10-29 11:31:04 PDT 
Comment on attachment 353288 [details]
Patch

still looks good to me
Comment 9 WebKit Commit Bot 2018-10-29 14:31:24 PDT 
Comment on attachment 353288 [details]
Patch

Clearing flags on attachment: 353288

Committed r237568: <https://trac.webkit.org/changeset/237568>
Comment 10 WebKit Commit Bot 2018-10-29 14:31:25 PDT 
All reviewed patches have been landed.  Closing bug.