Bug 190659

Summary: [JSC] More aggressively use `constexpr` in LowLevelInterpreter.asm for constant values
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
keith_miller: review+
Patch none

Yusuke Suzuki
Reported 2018-10-17 00:57:50 PDT
[JSC] More aggressively use `constexpr` in LowLevelInterpreter.asm for constant values
Attachments
Patch (35.29 KB, patch)
2018-10-17 01:08 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
Patch (35.33 KB, patch)
2018-10-17 08:00 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-10-17 01:08:12 PDT
Created attachment 352556 [details] Patch
EWS Watchlist
Comment 2 2018-10-17 01:11:37 PDT
Attachment 352556 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:101: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:105: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 3 2018-10-17 07:23:13 PDT
Comment on attachment 352556 [details] Patch r=me. I could have sworn I did some of these already... Oh well. Nice patch!
Yusuke Suzuki
Comment 4 2018-10-17 08:00:00 PDT
Created attachment 352566 [details] Patch
EWS Watchlist
Comment 5 2018-10-17 08:02:20 PDT
Attachment 352566 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:101: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:105: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 6 2018-10-17 08:49:02 PDT
Committed r237220: <https://trac.webkit.org/changeset/237220>
Radar WebKit Bug Importer
Comment 7 2018-10-17 08:50:43 PDT
<rdar://problem/45339486>
Note You need to log in before you can comment on or make changes to this bug.