Bug 190623

Summary: [GLib] Build error with RemoteInspector disabled
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Philippe Normand
Reported 2018-10-16 09:49:40 PDT
build-webkit --gtk --cmakeargs="-DENABLE_REMOTE_INSPECTOR=OFF" In file included from ../../Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:35: ../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:115: error: ‘RemoteInspector’ in namespace ‘Inspector’ does not name a type WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&); ^~~~~~~~~~~~~~~ In file included from ../../Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:35: ../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected unqualified-id before ‘::’ token WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&); ^~ ../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected ‘)’ before ‘::’ token WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&); ~ ^~ ) ../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected initializer before ‘::’ token WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&); ^~ [1562/1986] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource30.cpp.o
Attachments
Patch (3.88 KB, patch)
2018-10-16 10:03 PDT, Philippe Normand 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-10-16 10:03:48 PDT
Created attachment 352468 [details] Patch
EWS Watchlist
Comment 2 2018-10-16 10:05:41 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Philippe Normand
Comment 3 2018-10-16 10:54:27 PDT
Committed r237191: <https://trac.webkit.org/changeset/237191>
Note You need to log in before you can comment on or make changes to this bug.